test(e2e): cleanup timeout ms #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Oct 1, 2022
niklasad1
approved these changes
Oct 1, 2022
Imod7
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
LGTM! :)
Just a few questions of minor importance :
- I was wondering if it is worth having different timeouts for westend vs rest of chains.
- The choice of
60000forTIMEOUT_MSwas made based on which criteria ? I imagine the goal was to double the previous value of 30 seconds right ?
Thank you!!!
Unnecessary complexity, they can all be the same MS. The Timeout is there so just in case the request + test doesnt hang. This is a rare case in jest but it can happen.
The choice of 60000 was chosen because I have never really seen it go over 40000 before, but wanted to give it an extra buffer. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the timeout to a set const, and raises it. Raising the timeout is just in response to westend's responses being a bit a longer than the other chains. This avoids any testing failing for timeouts.