Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nomination pools support #1095

Merged
merged 20 commits into from
Jan 16, 2023
Merged

feat: add nomination pools support #1095

merged 20 commits into from
Jan 16, 2023

Conversation

marshacb
Copy link
Collaborator

@marshacb marshacb commented Oct 20, 2022 •
edited
Loading

Related issue: #1064

@TarikGul
Copy link
Member

Looks good so far! Great job!

@marshacb marshacb marked this pull request as ready for review October 26, 2022 16:46
@marshacb marshacb requested a review from a team as a code owner October 26, 2022 16:46
@marshacb marshacb self-assigned this Oct 26, 2022
@marshacb marshacb added the A0 - Please Review PR is ready for review label Oct 26, 2022
TarikGul
TarikGul approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good Job, looks great to me

Imod7
Imod7 requested changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some small things in case you would like to add them. Apart that Great work! 💯

src/controllers/pallets/PalletsNominationPoolsController.ts Show resolved Hide resolved
src/controllers/pallets/PalletsNominationPoolsController.ts Show resolved Hide resolved
src/services/pallets/PalletsNominationPoolsService.ts Show resolved Hide resolved
@marshacb marshacb requested a review from a team as a code owner December 19, 2022 16:00
@marshacb marshacb requested a review from Imod7 December 19, 2022 16:05
Imod7
Imod7 requested changes Jan 10, 2023
View reviewed changes
docs/src/openapi-v1.yaml Show resolved Hide resolved
@marshacb marshacb requested a review from Imod7 January 11, 2023 17:33
Imod7
Imod7 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marshacb marshacb merged commit 7534b1e into master Jan 16, 2023
@marshacb marshacb deleted the cameron-add-nomination-pools-support branch January 16, 2023 12:58
@TarikGul TarikGul mentioned this pull request Jan 24, 2023
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@Imod7 Imod7 Imod7 approved these changes

Assignees

@marshacb marshacb

Labels
A0 - Please Review PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marshacb @TarikGul @Imod7