Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase bench threshold #1102

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Conversation

TarikGul
Copy link
Member

This will increase the benchmarks threshold so the repo doesn't get flooded with regression issues.

This will all get solved once #1044 goes in.

@TarikGul TarikGul requested a review from a team as a code owner October 25, 2022 16:24
@TarikGul TarikGul requested a review from a team October 25, 2022 16:24
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niklasad1
Copy link
Member

niklasad1 commented Oct 27, 2022

I suggest that we talk to @alvicsam and setup something similar as we have in jsonrpsee instead of having these hardcoded threshold value which isn't scalable.

Should be possible to copy-paste: https://github.com/paritytech/jsonrpsee/blob/master/.github/workflows/benchmarks_gitlab.yml
and ask @alvicsam so push the benchmark results to the gh-pages branch. You need to modify GHA for js but should be trivial I think.

The benefit is that you could modify threshold and get nice graphs published on the gh pages similar to https://paritytech.github.io/jsonrpsee/bench/dev2/

@TarikGul @marshacb thoughts?

@TarikGul
Copy link
Member Author

I suggest that we talk to @alvicsam and setup something similar as we have in jsonrpsee instead of having these hardcoded threshold value which isn't scalable.

Should be possible to copy-paste: https://github.com/paritytech/jsonrpsee/blob/master/.github/workflows/benchmarks_gitlab.yml and ask @alvicsam so push the benchmark results to the gh-pages branch. You need to modify GHA for js but should be trivial I think.

The benefit is that you could modify threshold and get nice graphs published on the gh pages similar to https://paritytech.github.io/jsonrpsee/bench/dev2/

@TarikGul @marshacb thoughts?

I agree, and I think as I pass on this PR to the team #1044, it should be implemented as such in there.

@TarikGul TarikGul merged commit d0defe0 into master Oct 27, 2022
@TarikGul TarikGul deleted the tarik-reduce-bench-ms-regression branch October 27, 2022 13:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants