Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump follow-redirects from 1.14.7 to 1.15.2 in /docs #1118

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2022

Bumps follow-redirects from 1.14.7 to 1.15.2.

Commits
  • 9655237 Release version 1.15.2 of the npm package.
  • 6e2b86d Default to localhost if no host given.
  • 449e895 Throw invalid URL error on relative URLs.
  • e30137c Use type functions.
  • 76ea31f ternary operator syntax fix
  • 84c00b0 HTTP header lines are separated by CRLF.
  • d28bcbf Create SECURITY.md (#202)
  • 62a551c Release version 1.15.1 of the npm package.
  • 7fe0779 Use for ... of.
  • 948c30c Fix redirecting to relative URL when using proxy
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.15.2.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.15.2)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner October 28, 2022 14:39
@dependabot dependabot bot added D0 - Dependencies Pull requests that update a dependency file javascript labels Oct 28, 2022
peerDependenciesMeta:
debug:
optional: true
checksum: f6d03e5e30877431065bca0d1b2e3db93949eb799d368a5c07ea8a4b71205f0349a3f8f0191bf13a07c93885522834dca1dc8e527dc99a772c6911fba24edc5f
checksum: faa66059b66358ba65c234c2f2a37fcec029dc22775f35d9ad6abac56003268baf41e55f9ee645957b32c7d9f62baf1f0b906e68267276f54ec4b4c597c2b190
Copy link
Contributor

@Imod7 Imod7 Oct 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick question for when reviewing dependency updates from the dependabot :
When checking a package update from dependabot :

  • I check that the version is aligned with the one published in npm
  • Is there a way to also check that the checksum is correct ? to make sure that we are using the correct dependency and not a malicious one. I tried different things like :
    1. I checked in the npm registry > under versions > 1.15.2 > dist > shasum
      but the hash looks different than the one shown here

    2. I also downloaded the tar file of follow-redirects and then tried to check the hash with the corresponding command or generate it with different algorithms (256, 512, etc) but still it looks different.

    3. Based on this article

      As part of the generation of the yarn.lock file, yarn will compute a hash value for each dependency install based on the contents that were downloaded. Next time you download that dependency, yarn generates the hash again.
      If there is a mismatch between the new value and the value stored in yarn.lock, yarn will throw an error

      So maybe there is no point of checking it if this hash is generated by yarn ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So PR's such as this are not things that need to be overly reviewed. Just reading either the commits, or changelog if its there by dependabot is enough. Dependabot leverages the Github security advisory, so there is no need checking the checksum, etc. It would just be doing the work the Dependabot and Github do for us already.

@marshacb marshacb merged commit b5a991b into master Nov 10, 2022
@marshacb marshacb deleted the dependabot/npm_and_yarn/docs/follow-redirects-1.15.2 branch November 10, 2022 16:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0 - Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants