Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calc): remove sp-arithmetic-legacy #1146

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix(calc): remove sp-arithmetic-legacy #1146

merged 1 commit into from
Nov 30, 2022

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Nov 23, 2022

This removes sp-arithmetic-legacy from calc. It's no longer used in substrate/calc and we dont need to have it in the repo. Can be considered older tech/debt and bloat. This should be followed by a new patch release of calc.

@TarikGul TarikGul requested a review from a team as a code owner November 23, 2022 21:14
Copy link
Contributor

@CurlyBracketEffect CurlyBracketEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@TarikGul TarikGul merged commit 92f02dc into master Nov 30, 2022
@TarikGul TarikGul deleted the tarik-sec-update branch November 30, 2022 15:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants