fix: set rpc to call for queryInfo in transaction/fee-estimate #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
added
A0 - Please Review
IkerAlus
reviewed
Dec 22, 2022
| @@ -32,9 +32,20 @@ export class TransactionFeeEstimateService extends AbstractService { | |||
| transaction: string | |||
| ): Promise<RuntimeDispatchInfo> { | |||
| const { api } = this; | |||
| const apiAt = await api.at(hash); | |||
There was a problem hiding this comment.
for my understanding, what is the difference of pulling the hash at this point and not inside the try?
There was a problem hiding this comment.
No big difference, more so for readability. The try is really just dealing with the async call whereas establishing the api.at() is declaring the runtime api.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the use of RPC calls for queryInfo to runtime calls for
/transaction/fee-estimate. Will use rpc as a fallback.