-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add /pallets/errors #1176
Conversation
@marshacb Can you please include a detailed description in the PR about the feature, it's a bit easier to digest and compare what is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So overall, really great PR. Just want to get your thoughts on some of the questions below. Also if we should make some sort of AbstractPalletsService
for some of the logic below if it's to be reused.
One more addition as well, let's add these endpoint to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, just some small nits. 👍
remove newline
update latest polkadot e2e tests with PhragmentElection Pallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great to me! 💯
Summary: An endpoint that returns the errors for a given pallet
/pallets/{palletId}/errors
Query Params
at
: Which block to query, it will default to the latest finalized block. Accepts a hash or blocknumberonlyIds
: boolean to return only the Ids of each error instead of the entirety of each errorSample response for /pallets/democracy/errors?onlyIds=true
/pallets/{palletId}/errors/{errorItemId}
Query Params
at
: Which block to query, it will default to the latest finalized block. Accepts a hash or blocknumbermetadata
: boolean to choose whether to include an errors metadata in the responseSample response for /pallets/democracy/errors/ValueLow