Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace rpc calls for fees and give support for weight v1 and v2 #1177

Merged
merged 4 commits into from
Jan 9, 2023
Merged

fix: replace rpc calls for fees and give support for weight v1 and v2 #1177

merged 4 commits into from
Jan 9, 2023

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Jan 5, 2023 •
edited
Loading

This replaces the rpc calls with runtime calls, and fizes the bug for weights, regarding both weights v1, and weights v2.

closes: #1153

@TarikGul TarikGul requested a review from a team as a code owner January 5, 2023 19:02
marshacb
marshacb approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@TarikGul TarikGul changed the title fix: replace rpx calls for fees and give support for weight v1 and v2 fix: replace rpc calls for fees and give support for weight v1 and v2 Jan 6, 2023
Imod7
Imod7 reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't rpc.payment be replaced also in the .spec file ?

@TarikGul
Copy link
Member Author

TarikGul commented Jan 6, 2023

Shouldn't rpc.payment be replaced also in the .spec file ?

Yup, great catch. It can just be removed, as I replaced the actual mockHistoricApi with the call instead.

@Imod7 Imod7 mentioned this pull request Jan 6, 2023
Merged
@TarikGul
Copy link
Member Author

TarikGul commented Jan 6, 2023

@Imod7 Should be all good now. I also specified the test-helpers better in 79c6e63

Imod7
Imod7 approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/services/test-helpers/mock/mockApi.ts Outdated Show resolved Hide resolved
@TarikGul TarikGul merged commit 9bdaf45 into master Jan 9, 2023
@TarikGul TarikGul deleted the tarik-include-fee branch January 9, 2023 15:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshacb marshacb marshacb approved these changes

@Imod7 Imod7 Imod7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] transaction-pool unwrapping undefined.
3 participants
@TarikGul @marshacb @Imod7