Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add e2e-tests to single lint configuration #1226

Merged
merged 3 commits into from
Feb 13, 2023
Merged

chore: add e2e-tests to single lint configuration #1226

merged 3 commits into from
Feb 13, 2023

Conversation

TarikGul
Copy link
Member

This PR:

  • Adds the e2e-tests to be part of the single lint config.
  • Cleans up the package.json
  • Lints the previously non linted e2e files.

Now moving forward all ts, and js files will be linted using the same command.

@TarikGul TarikGul requested a review from a team as a code owner February 12, 2023 20:37
marshacb
marshacb approved these changes Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@marshacb marshacb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with conflicts fixed lgtm!

@TarikGul TarikGul merged commit f546abc into master Feb 13, 2023
@TarikGul TarikGul deleted the tarik-lint-e2e branch February 13, 2023 15:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshacb marshacb marshacb approved these changes

@Imod7 Imod7 Imod7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TarikGul @marshacb @Imod7