feat: add SAS_EXPRESS_KEEP_ALIVE_TIMEOUT #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshacb
approved these changes
Feb 17, 2023
TarikGul
commented
Feb 17, 2023
tetz-akaneya
reviewed
Mar 3, 2023
CurlyBracketEffect
approved these changes
Mar 7, 2023
| @@ -157,8 +157,7 @@ For more information on our configuration manager visit its readme [here](https: | |||
|
|
|||
| - `SAS_EXPRESS_BIND_HOST`: address on which the server will be listening, defaults to `127.0.0.1`. | |||
| - `SAS_EXPRESS_PORT`: port on which the server will be listening, defaults to `8080`. | |||
| - `SAS_EXPRESS_LOG_MODE`: enable console logging of "all" HTTP requests, only "errors", or nothing by | |||
There was a problem hiding this comment.
Is SAS_EXPRESS_LOG_MODE being removed as a valid configuration value?
There was a problem hiding this comment.
Funny, but also weirdly enough it's a very old legacy mode which has been removed for a while now.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1231
Allow sidecar to expose
SAS_EXPRESS_KEEP_ALIVE_TIMEOUTas a enviornment variable. It expects a number value, and it defaults to 5 is if nothing inputted (That is the default express value).