-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: update polkadot-js, and adjust for breaking changes (/accounts/{accountId}/balance-info
)
#1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
changed the title
[WIP] chore(deps): update polkadot-js
fix!: update polkadot-js, and adjust for breaking changes (Apr 9, 2023
/accounts/{accountId}/balance-info
)
marshacb
reviewed
Apr 10, 2023
marshacb
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor spelling nit. Looks great to me!
Co-authored-by: Cameron Marshall <cameron.marshall12@gmail.com>
CurlyBracketEffect
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 🤯
👍
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
The following PR introduces some minor breaking changes to
/accounts/{accountId}/balance-info
but breaking none the less.Summary
With paritytech/substrate#12951 merged we now need to take into account that the AccountInfo provided from
api.query.system.account
will not return the same format. Previously bothmiscFrozen
andfeeFrozen
were returned whereas now onlyfrozen
is returned. In order to keep historical integrity we have kept each field, and addedfrozen
as a new key. This breaking change being, when a specific key is not supported in the runtime instead of a balance being inputted into the key, it will have a message like'miscFrozen does not exist for this runtime'
. A sample return value would be:The new return type looks like:
Additional Notes:
The historical e2e-tests were all updated.
Unit tests are tracked in this issue: #1262
Additional Changes:
There was also a local type change from
PolkadotPrimitivesV2CandidateReceipt
toPolkadotPrimitivesV4CandidateReceipt
. This change does not impact any users.