Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validator staking endpoint with more info, and correct docs. #1258

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Apr 6, 2023

This adds a field called validatorsToBeChilled in the response, it also the at field which was missing. I also corrected the docs, and cleaned up the code. validatorsToBeChilled has accounts that may be in the validators field and I made sure to have that in the docs.

Response

{
  "at": {
    "hash": "string",
    "height": "string"
  },
  "validators": [
    {
      "address": "string",
      "status": "string"
    }
  ],
  "validatorsToBeChilled": [
    {
      "address": "string",
      "status": "string"
    }
  ]
}

Thanks to @Ank4n for info and clarification on the Storage query calls.

@TarikGul TarikGul requested a review from a team as a code owner April 6, 2023 01:13
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked in detail the new doc and looks on point. Good work.

Copy link
Contributor

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TarikGul TarikGul merged commit e0024e5 into master Apr 6, 2023
@TarikGul TarikGul deleted the tarik-add-validator-to-be-chilled branch April 6, 2023 21:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants