Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Change endpoints for e2e tests #1270

Merged
merged 2 commits into from
Apr 24, 2023
Merged

ci: Change endpoints for e2e tests #1270

merged 2 commits into from
Apr 24, 2023

Conversation

alvicsam
Copy link
Contributor

Use stable endpoints for e2e tests

Close #1268

@alvicsam alvicsam requested a review from a team as a code owner April 24, 2023 08:57
@alvicsam alvicsam requested a review from TarikGul April 24, 2023 09:17
@alvicsam
Copy link
Contributor Author

Hm, all tests have this error message:

2023-03-15 15:58:09 warn: `noMeta` query param will be deprecated in sidecar v13, and replaced with `metadata` please migrate
2023-03-15 15:58:09 error: RPC-CORE: peers(): Vec<PeerInfo>:: -32601: RPC call is unsafe to be called externally

but return code is 0 so CI thinks that tests are successful. @TarikGul is it planned?

@TarikGul
Copy link
Member

@alvicsam Yea those are expected, the first one is emitted via sidecar and is totally fine. The second one is emitted via polkadot-js and totally fine as well. I believe its's when we use this call specifically: rpc.system.localPeerId()

@TarikGul
Copy link
Member

Is it possible for us to also switch the benchmarking url over as well? :)

It's here.

@TarikGul TarikGul changed the title [ci] Change endpoints for e2e tests ci: Change endpoints for e2e tests Apr 24, 2023
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@TarikGul TarikGul merged commit 23f5b51 into master Apr 24, 2023
@TarikGul TarikGul deleted the as-ci-e2e branch April 24, 2023 12:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI]: Change benchmarking chain url's off of testing nodes
4 participants