Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update pjs api #1294

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix(deps): update pjs api #1294

merged 2 commits into from
Jun 12, 2023

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Jun 12, 2023

Changes

  • Updated packages:

    "@polkadot/api": "^10.9.1",
    "@polkadot/api-contract": "^10.9.1",
    "@polkadot/util-crypto": "^12.3.2",
    
  • Replaced Constructor with CodecClass
    I did this change because after updating the dependencies and building again with yarn build, I would get this error

    **src/test-helpers/typeFactory.ts:24:2 - error TS2305: Module '"@polkadot/types/types"' has no exported member   'Constructor'.
    Found 1 error in src/test-helpers/typeFactory.ts:24**
    

    With the change, it builds and tests passes.

Tests

The tests that still fail are the latest e2e (yarn test:latest-e2e-tests) when I connect to Westend. These tests fail even without updating the dependencies. It might be related to the current issues that the Westend Chain faces (?).

@Imod7 Imod7 requested a review from a team as a code owner June 12, 2023 17:13
@Imod7 Imod7 merged commit fe8ef2e into master Jun 12, 2023
@Imod7 Imod7 deleted the domi-update-pjs branch June 12, 2023 19:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants