fix: rename wsurl endpoints to asset hub #1301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR are the following :
wsUrl
endpoints withasset-hub
asset-hub-<relay_chain>
to<relay_chain>-asset-hub
strictly in the places that isuser-facing
since :
wsUrl
endpoints were also updated in polkadot-js/apps PR #9526 (so we could replace one of the two exceptions from this PR #1296 )AssetHub<Relay>
orasset-hub-<relay>
and whatever is related to the "user" should be in the format<relay>-asset-hub
.Assumptions
I made the 2nd change with the assumption that
user
is also someone who is running the tests. If this assumption is not correct then I will rollback that change.Tests
Run the following tests :
yarn test:latest-e2e-tests --chain polkadot-asset-hub
yarn test:historical-e2e-tests --chain polkadot-asset-hub
yarn test:historical-e2e-tests --chain kusama-asset-hub
I had to update also this line because when I was running
yarn test:latest-e2e-tests --chain polkadot-asset-hub
I was getting the error :
This error is also present in the previous PR #1296 so right now in
master
branch (if you runyarn test:latest-e2e-tests --chain asset-hub-polkadot
) but I didn't catch it and neither did theCI
because at the end it says[PASSED] All Tests Passed!
Taking this into account, I was thinking that maybe we could change how we check the tests results. For example, if 0/10 tests were run, maybe we could throw an error also ?