Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update pjs util-crypto #1336

Closed
wants to merge 9 commits into from
Closed

Conversation

marshacb
Copy link
Collaborator

@marshacb marshacb commented Oct 2, 2023

No description provided.

@marshacb marshacb requested a review from a team as a code owner October 2, 2023 21:33
@TarikGul
Copy link
Member

TarikGul commented Oct 3, 2023

We need to be careful with this since 10.9.1 of @polkadot/api uses: 12.3.1 ie: https://github.com/polkadot-js/api/blob/ac07123e54946dd6ba3d80ea8c1ab90ab86aaaa2/packages/api/package.json#L37

There could be some dependency misalignment if we have 2 seperate versions in our dep tree.

@marshacb
Copy link
Collaborator Author

marshacb commented Oct 3, 2023

We need to be careful with this since 10.9.1 of @polkadot/api uses: 12.3.1 ie: https://github.com/polkadot-js/api/blob/ac07123e54946dd6ba3d80ea8c1ab90ab86aaaa2/packages/api/package.json#L37

There could be some dependency misalignment if we have 2 seperate versions in our dep tree.

Hey Tarik, Great catch! So being that pjs api doesn't support this latest version of util-crypto yet we can postpone this dep update.

@marshacb
Copy link
Collaborator Author

marshacb commented Oct 3, 2023

postponing updating util-crypto to avoid having 2 separate versions in deps

@marshacb marshacb closed this Oct 3, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants