Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): replace tests pointing to deprecated pallets #1363

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Dec 1, 2023

Description

This PR replaces the e2e/latest tests that are pointing to deprecated pallets.

Details

The polkadot runtime no longer has :

  • the Democracy pallet with index 14
  • the PhragmenElection pallet with index 17

The pallets and their indices can be found in previous versions of the polkadot runtime, e.g. Democracy and PhragmenElection.

Solution proposed

Instead of removing completely the tests I replaced them so they point to existing pallets.

Minor additional fix

Fixed some minor typos in methods names mentioned in the Pallets Services (in comments).

@Imod7 Imod7 requested a review from a team as a code owner December 1, 2023 17:32
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Imod7 Imod7 merged commit 2a38b2e into master Dec 1, 2023
19 checks passed
@Imod7 Imod7 deleted the domi-deprecated-pallets branch December 1, 2023 21:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants