Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: transactionPaidFee event optimization #1367

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Dec 21, 2023

This ensures no Promises are made when they are not needed.

Basic benchmarks showed we went from 70s queries to 3s.

@TarikGul TarikGul requested a review from a team as a code owner December 21, 2023 17:22
Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TarikGul TarikGul merged commit 2883249 into master Dec 21, 2023
15 checks passed
@TarikGul TarikGul deleted the tarik-fix-fromevent branch December 21, 2023 17:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants