ci: Replace helm deploy with argo cd #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BulatSaif
changed the title
|
Thanks for the PR! Does this make the current |
ArgoCD uses the same ./helm directory. If the directory is not needed here, I can move it to https://github.com/paritytech/helm-charts as most of our applications. |
alvicsam
approved these changes
Feb 5, 2024
Totally fine for the helm charts to exist in sidecar. It was just a base question to get a better understanding. Thanks again |
TarikGul
approved these changes
Feb 5, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://github.com/paritytech/devops/issues/2977
changes
helm deploycommand was replaced byargocd set/synccommand