Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: claimed in staking info endpoint #1445

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

fix: claimed in staking info endpoint #1445

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c65010a
fix: claimed in staking info endpoint
Imod7 Jun 4, 2024
50943e1
fix existing tests
Imod7 Jun 4, 2024
82457aa
add test for kusama (includes era 6508)
Imod7 Jun 7, 2024
9012e24
updated docs
Imod7 Jun 13, 2024
f320c08
implement new logic & update test responses
Imod7 Jun 14, 2024
2aa5996
add test for partially claimed & overview = null
Imod7 Jun 18, 2024
de06c6b
updated docs
Imod7 Jun 18, 2024
8c47eda
output up until 84 eras & update tests
Imod7 Jun 18, 2024
56e3738
merge master, update historical tests & code for lastReward
Imod7 Jun 20, 2024
9e838e8
Remove yarn.lock files from PR
Imod7 Jun 20, 2024
753f3ee
check before unwrapping & fix types
Imod7 Jun 21, 2024
7ac0236
run linter
Imod7 Jun 21, 2024
171e10a
docs: added links & updated schema description
Imod7 Jun 24, 2024
88be07e
updated logic of claimed field for validator account
Imod7 Aug 5, 2024
cd66735
fix for claimed in case of validator account
Imod7 Aug 6, 2024
00a54a0
moved validator logic in separate function
Imod7 Aug 22, 2024
df175e8
adding first draft of nominator logic
Imod7 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/dist/app.bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 19 additions & 4 deletions docs/src/openapi-v1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4259,11 +4259,26 @@ components:
format: unsignedInteger
claimedRewards:
type: array
description: Array of eras for which the stakers behind a validator have
claimed rewards. Only updated for _validators._
description: Array of objects, each containing an `era` and its corresponding `status`,
which represents the rewards status of the stakers backing a validator. Only updated
for _validators._ This array is populated with values from `stakingLedger.legacyClaimedRewards`
or `stakingLedger.claimedRewards`, as well as the `query.staking.claimedRewards` call, depending
on whether the queried block is before or after the migration. For more details on the implementation
and the migration, refer to the related PR and linked issue.
Copy link
Contributor

@IkerAlus IkerAlus Jun 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where/how can the user find the relevant linked info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added specific links of the PR and linked issue. Let me know if this covers your question. I also updated the schema description since I no longer return lastReward. Changes included in this commit.

items:
type: string
format: unsignedInteger
type: object
properties:
era:
type: string
description: The era for which we check the rewards status.
format: unsignedInteger
status:
type: string
description: The rewards status of the stakers backing a validator.
enum:
- claimed
- unclaimed
- partially claimed
description: The staking ledger.
StakingProgress:
type: object
Expand Down
Loading
Loading