Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 19.0.2 #1459

Merged
merged 1 commit into from
Jun 27, 2024
Merged

chore(release): 19.0.2 #1459

merged 1 commit into from
Jun 27, 2024

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Jun 27, 2024

Description

This release is a patch release because it includes:

  • multiple chore related PRs
  • one fix in the staking-info endpoint
  • an update of the pjs dependencies from v11.1.1 to v12.0.1

Notes

  1. The pjs-api release v12.0.1 introduced the possibility to add the CheckMetadataHash signed extension and was considered a major release. However, in the Sidecar side, it is considered as a regular dependency update since the usage of endpoints remains unchanged.
  2. Having said that, since this a very important addition in pjs-api I could also mention it as a Note in the release notes of Sidecar.
  3. In the Compatibility section of the Changelog (and subsequently in the release notes later), I changed the node version format. Based on the format followed previously, you would expect to see the node version as v11300 (for polkadot-sdk v1.13.0) but I changed it to v1013000. The reason is because I noticed that in the section Assets of v1.13.0 release notes, some assets are labeled as v1013000, e.g. asset-hub-rococo_runtime-v1013000.compact.compressed.wasm so I think this is the correct way to denote the client version. I will need to update the previous release notes and changelog to the correct format also.

Let me know if you have any feedback on the points mentioned above. Thank you!

@Imod7 Imod7 requested a review from a team as a code owner June 27, 2024 15:42
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Imod7 Imod7 merged commit 28ed90d into master Jun 27, 2024
15 checks passed
@Imod7 Imod7 deleted the domi-v19-0-2 branch June 27, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants