-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Optimize accounts/{accountId}/staking-payouts
blocking query complexity
#372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
requested review from
insipx,
niklasad1,
maciejhirsz,
mattrutherford and
dvdplm
December 20, 2020 05:36
dvdplm
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10x improvement! 🍰
Co-authored-by: David <dvdplm@gmail.com>
…ch/substrate-api-sidecar into zeke-optimizing-payouts
dvdplm
reviewed
Jan 4, 2021
TarikGul
approved these changes
Jan 7, 2021
lgtm |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely closes: #367
In the previous iteration of
AccountsStakingPayoutsService
we had M * N batched queries (read: queriesawait
-ed within aPromise.all
) , where M is the depth of eras and N is maximum number of validators nominated byaddress
at any given era.This PR dramatically reduces the endpoint complexity and response time by always only waiting for two batches of queries to resolve. So we have simplified the blocking query complexity from O(m*n) => O(1).
We achieve this by taking advantage of the fact that we can dynamically build arrays of promises wrap them in
await Promise.all
.Below is a picture of Sidecar logs, left is master and right is this branch (look at the end of log message for response time in milliseconds):