-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Update polkadot-js/api and account for chainProperties updates #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
changed the title
fix: Update polkadot-js/api and account for chainProperties updates
fix!: Update polkadot-js/api and account for chainProperties updates
Jan 26, 2021
TarikGul
reviewed
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
TarikGul
approved these changes
Jan 26, 2021
dvdplm
suggested changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new format merits a test or two?
TarikGul
reviewed
Jan 28, 2021
dvdplm
approved these changes
Jan 28, 2021
Co-authored-by: David <dvdplm@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
runtime/spec
response.tokenSymbol
andtokenDecimals
now return anArrary<string>
instead of astring
. See the diff forsrc/services/test-helpers/responses/runtime/spec.json
to view a concrete example of the change.chainProperties.chainTokens
. Formerly,chainProperties.chainToken
was just astring
; now it is aArray<string>
, so it can be extensible for chains that support multiple tokens. In this PR we make the assumption that the token at index 0 will be the native token. We consider a token native because its balance is stored insystem::Accounts
; opposed to a non-native token which has its balance accessible via the ORMLtokens
pallets.