fix: discriminate extrinsic_base_weight based on dispatch class
#414
Conversation
One way to handle this is once this PR is totally approved, |
There was a problem hiding this comment.
Logic checks out with me with me. My main concern is just making sure we give a decent effort with optimization. I mention it in my code comments, but
- we should only fetch metadata as needed and it should be parallel with other querys if possible (I think this would mean doing it with the querys that are currently in
createCalcFee. - we should only need to create the decorated metadata once. (Potentially all of this could be done in
createCalcFeeand the decorated metadata could be returned if relevant)
The one other thing is just make sure to bump calc to 0.2.0
package.json
Outdated
| @@ -39,7 +39,7 @@ | |||
| "@polkadot/api": "^3.6.4", | |||
| "@polkadot/apps-config": "^0.77.1", | |||
| "@polkadot/util-crypto": "^5.4.4", | |||
| "@substrate/calc": "^0.1.3", | |||
| "@substrate/calc": "file:./calc/pkg", | |||
There was a problem hiding this comment.
Just a reminder that this should be change to "^0.2.0" before it gets merged.
| weight, | ||
| len, | ||
| unadjusted_len_fee, | ||
| unadjusted_weight_fee, | ||
| adjustable_fee, | ||
| adjusted_fee, | ||
| base_fee, | ||
| result | ||
| ); | ||
|
|
There was a problem hiding this comment.
I think the Cargo.toml version should get bumped to "0.2.0" since this is a breaking change, but we are on major 0 so we just bump minor. After bumping in Cargo.toml you should be able to run build.sh and the package.json should update.
There was a problem hiding this comment.
Rad, thanks for explaining. Yea was a little confused at first with the versioning.
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
…ht is still false
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Info:
This PR addresses Issues #393. There were a number of changes to the structure of createCalcFee. Both on the typescript side and the rust-wasm package.
Changelog
@substrate/calc package (Rust-wasm)
./calc/src/calc_fee.rsIn this file I removed the
extrinsic_base_weightfromfrom_paramswhich was getting called increateCalcFeeonce, and moved it tocalc_fee. When fetch_block iterates through the extrinsic's it will callcalc_feeand recalculate the fee based on the extrinsic dispatch class.BlocksService (Typescript)
./src/services/blocks/BlocksService.tsAdded a private helper function
getParentParentHash.Removed the
blockparameter fromcreateCalcFeeand addedparentParentHashinstead. This is because the functioncreateCalcFeeonly took in the block parameter for theparentParentHashruntime work around (which I removed from the function). I needed to find the parentParentHash inside offetchBlockinstead, therefore for optimization purposes I removed it to avoid multiple rpc calls.I also transferred a lot of the
extrinsicBaseWeightlogic fromcreateCalcFeeand put it into fetchBlock where we iterate through the extrinsics. This is also why i make an rpc call for the metadata right before we iterate.Extra
The one issue I am not too sure about is publishing
@substrate/calc, currently I have the package set tofile:./calc/pkg, not sure if i should change it back, but the tests will break if I do because it uses the older calc_fee.