Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Update @polkadot/{apps-config, api} to get latest type definitions #434

Merged
merged 1 commit into from
Feb 15, 2021
Merged

fix(types): Update @polkadot/{apps-config, api} to get latest type definitions #434

merged 1 commit into from
Feb 15, 2021

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Feb 15, 2021

Changes:

  • bumps @polkadot/apps-config && @polkadot/api to latest stable releases which includes some type updates for chains in polkadot/apps and type updates for test parachains
  • Adjusts tests to use updated error enum type in polkadot-js (polkadot-js/api@15ba6f6)
  • Adjust types passed into ApiPromise from from polkadot/apps-config to no longer use typesSpec because apps-config no longer exports it. What was previously typesSpec is now included in typesBundle (Convert all specs to type bundles polkadot-js/apps#4646).

TarikGul
TarikGul approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emostov emostov merged commit e02818f into master Feb 15, 2021
@emostov emostov deleted the zeke-bump-392 branch February 15, 2021 20:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emostov @TarikGul