Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types)!: camelCase enum serialization; Bump polkadot/api@v4 w. ESM #467

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Mar 10, 2021

BREAKING CHANGE

Enums in responses serialize with camelCase variants. Check spec diffs for details

Other changes

  • Reverses regressions in decoding blocks with sudo proxy variants
  • Update Jest setup to handle @polkadot packages that now use ESM
    • Add babel config that converts JS files from CommonJS (CJS) to ECMASCript Modules (ESM).
    • Update Jest config to pipe all .js into babel and .ts into tsc and specify that @polkadot packages should be explicitly transformed (normally node_modules are ignored). Since @polkadot packages ship with .js files, they go through the bable transpiler and spit out the CJS that Jest expects.
  • Bump deps

BREAKING CHANGE
Enums in responses serialize with [camelCase variants](polkadot-js/api#3024). Check spec diffs for details

Other changes
- Reverses regressions in decoding blocks with [sudo proxy variants](polkadot-js/api#3286)
- Updates jest.config to treat `.js` files as ESM - transforming @polkadot/* packages from ESM to CJS.
- Bump deps
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one console.log().

src/sanitize/sanitizeNumbers.ts Outdated Show resolved Hide resolved
Co-authored-by: David <dvdplm@gmail.com>
@emostov emostov merged commit 179642b into master Mar 10, 2021
@emostov emostov deleted the zeke-esm-jest-prayers branch March 10, 2021 17:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants