fix: update eraElectionStatus for runtime upgrade v30 #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
suggested changes
Mar 23, 2021
|
@dvdplm Awesome I switched the conditional around to remove the |
emostov
suggested changes
Mar 23, 2021
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
emostov
reviewed
Mar 24, 2021
emostov
approved these changes
Mar 24, 2021
emostov
approved these changes
Mar 25, 2021
dvdplm
approved these changes
Mar 29, 2021
Comment on lines
+14
to
+18
| | { | ||
| status: AnyJson; | ||
| toggleEstimate: string | null; | ||
| } | ||
| | string; |
There was a problem hiding this comment.
dq: What do the |s do here?
There was a problem hiding this comment.
So here we have a Union Type, the first | denotes that the type has not yet been decided but it will guaranteed be one of the following below. And all following |'s are there to allow electionStatus to fulfill multiple types.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #468.
Updated
eraElectionStatusto work for parachains, but also to work with the upcoming runtime upgrade.With the upcoming runtime Upgrade v30,
eraElectionStatuswill no longer be supported and therefore deprecated.