feat: Experimental PLO endpoints #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add crowdloan routes to the ParasController * add crowdloan routes functionality in the ParaService * fix: remove parseFundInfo, cleanup types * cleanup comments * fix type * add types for crowdloans route * cleanup service and controller * remove todo * fix: types for paraId, fix fundInfo query param, optimize entries
* Update auctions current to use offset to key into Winning * MVP leases current * Add paras service * Add /paras to controller * Update doc comments * Add retirement end * Add response interfaces * Add interfaces for leases, para, and auctions * Add doc comment to interface * Exclude lease-info for indexs with no lease * Remove retirement period end bc no longer have retirements * Address tarik review comment * Apply suggestions from code review Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com> Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
…ritytech/substrate-api-sidecar into feat-experiment-plo-endpoints
* feat: include lease set for each winning bid in auctions/current * Rename some vars * Update comment
|
Some of the hardcoded values for when we enumerate lease periods will need to be updated to reflect github.com/paritytech/polkadot/pull/2862 Ideally we can pull the slot range dynamically |
TarikGul
reviewed
Apr 9, 2021
feat: add testing for plo endpoints (#512) Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
…ritytech/substrate-api-sidecar into feat-experiment-plo-endpoints
TarikGul
reviewed
Apr 13, 2021
TarikGul
reviewed
Apr 13, 2021
TarikGul
reviewed
Apr 13, 2021
TarikGul
reviewed
Apr 13, 2021
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
emostov
commented
Apr 13, 2021
|
Sanity and edge cases manually tested:
Let me know if you can think of other potential tests. |
We could do a check in |
TarikGul
approved these changes
Apr 14, 2021
* fix: typefactory, and cleanup mockApi
dvdplm
reviewed
Apr 16, 2021
Co-authored-by: David <dvdplm@gmail.com>
|
@dvdplm everything from your reviews should be addressed now |
dvdplm
approved these changes
Apr 19, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces the following endpoints for parachain lease offerings:
/experimnetal/paras/experimental/paras/auctions/current/experimental/paras/{paraId}/crowdloan-info/experimental/paras/crowdloans/experimental/paras/{paraId}/lease-info/experimental/paras/leases/currentThese are considered experimental as we may break the API without bumping api-sidecar's major version.
Closes: #490
cc @CurlyBracketEffect @joepetrowski