Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: integrate runtime-tests as a helper library #549
test: integrate runtime-tests as a helper library #549
Changes from 31 commits
c19211c
1c1cca7
83cba6f
ff4dd7b
169120f
31761ba
9ad3233
11a0c8e
dbe4d1d
18d8050
6631813
bd0333e
8731c57
77266a7
58ff145
6a4b149
6f2c253
19b6f3e
5c2023f
67896bb
a876e73
d4fccec
73ea3dd
ab7833e
e098fb2
a6ccdad
29d7f82
414b7ae
ec9a028
de4184b
491cee5
c9a914b
7f73b6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool if we had our own nodes - but I supposed you could not check the addresses into source control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could input the URLs as either
CLI args
or setenv variables
for them instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I agree having our own nodes would be very nice. Would be a nice addition for the tools team in general.