fix: reduce controller config boilerplate #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
approved these changes
May 17, 2021
There was a problem hiding this comment.
Code looks good but need to update docs here: https://github.com/paritytech/substrate-api-sidecar/blob/master/CHAIN_INTEGRATION.md#1-create-a-controller-config
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #544
Per the issue, I have reduced the boilerplate for controllers to the following:
controllers: ['Blocks', 'BlocksExtrinsics', ....]Moving forward chain-configs should only contain the controllers they wish to use, and any other controller that is absent wont be mounted for the instance.