Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Extracting winners from a closed auction guide #577

Merged
merged 30 commits into from
Jun 23, 2021

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Jun 7, 2021

This guide is to be migrated to the polkadot.wiki and will help exchanges leverage sidecars endpoints in order to find out the winners of a specific auction.

AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure and content is good. Mostly just suggestions on wording to keep things concise

See comments for details

@emostov emostov requested a review from dvdplm June 8, 2021 04:51
TarikGul and others added 4 commits June 8, 2021 12:05
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
TarikGul and others added 2 commits June 9, 2021 10:51
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
@TarikGul TarikGul marked this pull request as ready for review June 15, 2021 03:11
@emostov emostov self-requested a review June 15, 2021 03:14
guides/AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved
guides/AUCTIONS_WINNERS.md Outdated Show resolved Hide resolved

By storing the `finishEnd` block and looking at the `Leased` events within it, we can see who the auction winners are and what lease periods they were rewarded.

The next important part is the `leasePeriods` that corresponds to the current `auctionIndex`. We use these available `leasePeriods` to compare the winning results and see which `paraId`'s took which slots. (Note that this is a redundant way to find the auction winners when coupled with watching for the `Leased` events)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant and less granular - it does not explicitly say which auction they won the slots from and multiple auctions may cover the same set of slots.

TarikGul and others added 2 commits June 15, 2021 07:48
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
@dvdplm dvdplm requested a review from emostov June 21, 2021 14:27
@dvdplm dvdplm merged commit 4285537 into master Jun 23, 2021
@dvdplm dvdplm deleted the tarik-auctions-guide branch June 23, 2021 14:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants