fix: createCalcFee bug #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
approved these changes
Jun 22, 2021
|
Yea just noticed that, putting a better message in there. Good question for sure! Fixed the error message |
niklasad1
approved these changes
Jun 23, 2021
dvdplm
approved these changes
Jun 23, 2021
dvdplm
reviewed
Jun 23, 2021
| @@ -19,6 +20,7 @@ import block7354817 from './7354817.json'; | |||
| import block7519631 from './7519631.json'; | |||
|
|
|||
| export const kusamaEndpoints = [ | |||
| ['/blocks/9253', JSON.stringify(block9253)], //v1020 | |||
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] Urgent
Using Kusama as an example querying any block with a runtime less than 1062 (the minimum runtime version used to calc fees for kusama) will throw an error because
api.query.transactionPayment?.nextFeeMultiplier?.atMultipliertype isnt supported.Currently there is no check before
api.query.transactionPayment?.nextFeeMultiplier?.atto make sure we don't calculate any fees for runtime's less than the least known runtime for fee's.This PR fixes that by adding a check.