Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the runtime versions used in the blockstore, and e2e tests #592

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

TarikGul
Copy link
Member

Updates sidecar's cache for runtime versions used to calc fees.

Updates the e2e tests for kusama and polkadot for the most up to date runtimes.

Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should document how to go about performing this chore.

@TarikGul
Copy link
Member Author

We should document how to go about performing this chore.

I agree, it could potentially fit within the release docs, but I don't want to make it anymore cumbersome than it already can be sometimes with the e2e tests.

Maybe a "Maintaining" section in the Readme, that can have detailed instructions on some of the manual steps we take to update things such as this.

@dvdplm
Copy link
Contributor

dvdplm commented Jun 29, 2021

Maybe a "Maintaining" section in the Readme, that can have detailed instructions on some of the manual steps we take to update things such as this.

Automating it would be the ultimate fix ofc, but yeah, the first step should be just writing it down somewhere.

@dvdplm dvdplm merged commit 4e42877 into master Jun 29, 2021
@dvdplm dvdplm deleted the tarik-update-metadataconsts branch June 29, 2021 18:36
@TarikGul TarikGul mentioned this pull request Jul 1, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants