-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add vrfDelay
as a phase
return value for ongoing auctions to reflect VRFdelays in polkadot
#593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - just some suggestions on docs and the name of the enum variants .. although i am not sure if appending Period
is worth it to align with better with https://github.com/paritytech/polkadot/blob/60341e125563cbf655ab686ac5cef370ac33d16d/runtime/common/src/traits.rs#L150-L164
delay
as a phase
return value for ongoing auctions to reflect VRFdelays in polkadotvrfDelay
as a phase
return value for ongoing auctions to reflect VRFdelays in polkadot
@emostov This is ready to merge, just want to make sure whether we should append |
Its already a breaking change because when we used to show |
Ahh yes, the breaking change is there regardless because the new runtime logic is keeping |
closes: #588
Breaking Change
Summary
This PR aims to reflect the addition of the
AuctionStatus
enum in polkadot for parachains, specifically theVRFDelay
. When an auction is past itsfinishEnd
block the auction is then in avrfDelay
phase.Changes
I updated the tests to reflect this change, I also spotted a minor issue in the tests and reversed the output results to reflect a real world scenario with the auctions.
Added logic inside of the
auctionsCurrent
method forParasService
that will add avrfDelay
phase as a potential result.I added the
vrfDelay
result to theAuctionPhase
type, and changedstarting
=>startPeriod
,ending
=>endPeriod
.Overall there are 3 potential return values for a phase: