fix: add --version flag

[TarikGul]

closes: #484

This adds the version flag for sidecar, but currently there is some unknown default behavior that should be resolved before this is merged.

Run: yarn build && yarn start --version

Current output:

SAS:
  📦 LOG:
     ✅ LEVEL: "info"
     ✅ JSON: false
     ✅ FILTER_RPC: false
     ✅ STRIP_ANSI: false
  📦 SUBSTRATE:
     ✅ WS_URL: "wss://rpc.polkadot.io"
     ✅ TYPES_BUNDLE: undefined
     ✅ TYPES_CHAIN: undefined
     ✅ TYPES_SPEC: undefined
     ✅ TYPES: undefined
  📦 EXPRESS:
     ✅ BIND_HOST: "127.0.0.1"
     ✅ PORT: 8080
@substrate/api-sidecar v9.0.0

I am under the impression that this could be the root of the issue, but I need to do some more digging.

It originated from this import, then trickles down to ./controllers all the way to anywhere validateAddress is imported in, such as all the Account Controllers.

Update:

This is fixed, and working as it should!

[emostov]

but currently there is some unknown default behavior that should be resolved before this is merged.

Whats the exact behavior that is unexpected?

[TarikGul]

@emostov The "unknown" issue is just SAS is logging/printing the below by just importing files. As in without initializing anything this will always print if main.ts is called.

SAS:
  📦 LOG:
     ✅ LEVEL: "info"
     ✅ JSON: false
     ✅ FILTER_RPC: false
     ✅ STRIP_ANSI: false
  📦 SUBSTRATE:
     ✅ WS_URL: "wss://rpc.polkadot.io"
     ✅ TYPES_BUNDLE: undefined
     ✅ TYPES_CHAIN: undefined
     ✅ TYPES_SPEC: undefined
     ✅ TYPES: undefined
  📦 EXPRESS:
     ✅ BIND_HOST: "127.0.0.1"
     ✅ PORT: 8080

[emostov]

@TarikGul try moving this line inside of main:

substrate-api-sidecar/src/main.ts

Line 34 in 5a78903

const { config } = SidecarConfig;

I think its calling the getter here:

substrate-api-sidecar/src/SidecarConfig.ts

Lines 70 to 72 in 5a78903

	static get config(): ISidecarConfig {
	return this._config || this.create();
	}

[TarikGul]

@TarikGul try moving this line inside of main:

substrate-api-sidecar/src/main.ts

Line 34 in 5a78903

const { config } = SidecarConfig;

I think its calling the getter here:

substrate-api-sidecar/src/SidecarConfig.ts

Lines 70 to 72 in 5a78903

	static get config(): ISidecarConfig {
	return this._config || this.create();
	}

Yea I had tried this earlier when trying to debug it and it didn't work, that could be another source of where it could be coming from though, but I also can confirm that in this file specifically this line it's being called during the imports.

But that being said it I think it could be initializing in more than one place too.

[TarikGul]

@emostov I did make some progress on it, looks like you were right in one respect. consoleTransport had the same issue with SidecarConfig which you pointed out in main. So three cases where it shows up is now solved (main.ts, consoleTransport.ts). The issue is still coming up, but I think I should have it solved shortly after having those 3 sorted out.

[emostov]

💯

[jsdw]

Code looks good to me, and it does what it says on the tin :)