Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added SORA network controller #625

Merged
merged 5 commits into from
Jul 31, 2021
Merged

fix: Added SORA network controller #625

merged 5 commits into from
Jul 31, 2021

Conversation

pgolovkin
Copy link
Contributor

Added SORA network controller

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jul 30, 2021

User @pgolovkin, please sign the CLA here.

TarikGul
TarikGul approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I tested it against wss://mof3.sora.org and it all checked out. Just one minor grumble with a comment spelling error.

@TarikGul TarikGul requested review from emostov, insipx and jsdw July 30, 2021 14:10
@TarikGul
Copy link
Member

Also before merging, @pgolovkin if you could run yarn lint --fix to fix the CI check.

Thanks again.

@TarikGul TarikGul changed the title Added SORA network controller fix: Added SORA network controller Jul 31, 2021
@TarikGul TarikGul merged commit f1511c4 into paritytech:master Jul 31, 2021
@jsdw jsdw mentioned this pull request Aug 2, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insipx insipx insipx approved these changes

@TarikGul TarikGul TarikGul approved these changes

@emostov emostov Awaiting requested review from emostov

@jsdw jsdw Awaiting requested review from jsdw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgolovkin @TarikGul @insipx