-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update polkadot-js deps #677
Conversation
Not Ready to merge as this breaks a lot of Example: querying
|
@@ -143,7 +138,7 @@ describe('BlocksService', () => { | |||
|
|||
it('Return an error with a null calcFee when perByte is undefined', async () => { | |||
mockApi.consts.transactionPayment.transactionByteFee = | |||
undefined as unknown as BalanceOf & AugmentedConst<'promise'>; | |||
undefined as unknown as u128 & AugmentedConst<'promise'>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the & AugmentedConst<'promise'>
part do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So an AugmentedConst takes in an ApiType
-> AugmentedConst<ApiType>
. ApiType
is a union of 'promise' | 'rxjs'
. The way I interperate it is its a wrapper type that denotes what type of ApiType is involved with the const. In this case transactionByteFee
. That being said this same wrapper exists for query
-> AugmentedQuery
, rpc
, and so on.
Co-authored-by: David <dvdplm@gmail.com>
This updates polkadot-js to 6.0.5 which has some major changes.
Places where we were affected:
AccountAssetsBalances
: We no longer receive theAssetBalance
type butPalletAssetsAssetBalance
instead which changesisSufficient
->sufficient
. I made sure to account for runtimes that have eitherisSufficient
orsufficient
keys. MockApi also had to be adjusted.Changed
BalanceOf
tou128
in theBlocksService
test suiteThe
PalletsStorage
service uses V12 as (asLatest
) in order to get the{ modules }
, but now with V14 the metadata return{ pallets }
, this fix is to make sure the current api doesnt break. But that being said the endpoint needs to be updated to deal with V14 as well. Tracking issue here Issue #678;