fix(deps): bump polkadot/api, cleanup resolutions #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
approved these changes
Oct 2, 2021
niklasad1
reviewed
Oct 2, 2021
| @@ -295,7 +295,7 @@ All the commits in this repo follow the [Conventional Commits spec](https://www. | |||
| - @polkadot/util-crypto [release notes](https://github.com/polkadot-js/common/releases) | |||
| - @substrate/calc [npm release page](https://www.npmjs.com/package/@substrate/calc) | |||
|
|
|||
| 1. Next make sure the resolutions are up to date inside of the `package.json` to match polkadot-js [here](https://github.com/polkadot-js/apps/blob/master/package.json). This is a manual process, and the packages we want to update are only the ones with `@polkadot` appended to it. If any issues may surface, contact the maintainers. | |||
| 1. Next make sure the resolutions are up to date inside of the `package.json` for all `@polkadot/*` packages, please refer to the releases of each polkadot package we update as a dependency, and reach out to the maintainers for any questions. | |||
There was a problem hiding this comment.
hmm, that sounds like polkadot-js changelog/release log is not detailed enough but fine...
There was a problem hiding this comment.
Well actually its that, more often than not were are a little out of line with polkadot-js/apps, because its the last thing in the chain of releases. Sometimes it off for what we need, and causes confusion, or may even cause a bug if our resolutions don't match somewhere.
niklasad1
approved these changes
Oct 2, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the resolutions and bumps
@polkadot/apito v6.1.2