fix: expandMetadata for historic runtimes #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
requested review from
dvdplm,
maciejhirsz,
jsdw,
insipx and
niklasad1
niklasad1
reviewed
Oct 5, 2021
| @@ -558,9 +558,10 @@ export class BlocksService extends AbstractService { | |||
| blockHash: BlockHash | |||
| ): Promise<WeightValue> { | |||
| const metadata = await api.rpc.state.getMetadata(blockHash); | |||
| const historicApi = (await api.at(blockHash)) as ApiPromise; | |||
There was a problem hiding this comment.
@TarikGul I suppose the registry contains metadata, chain info and other stuff that is required for that data to match for historical blocks?
There was a problem hiding this comment.
Yup exactly!
Example: The specific error that brought up this issue too was a type error where Westend has a Lookup36 type in its Metadata, but it didnt match the registry. So when trying to expand the metadata, types didn't align.
insipx
approved these changes
Oct 5, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #690
This fixes a bug where when expanding metadata in order to capture the weights used in calculating we dont use the correct registry per historic block. This changes that to have a historicApi return the correct registry for the block.