fix(tests): restructure mockApi tests to integrate with historical api #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
TarikGul
requested review from
emostov,
dvdplm,
niklasad1,
insipx,
jsdw and
maciejhirsz
insipx
approved these changes
Oct 11, 2021
dvdplm
approved these changes
Oct 12, 2021
| ...defaultMockApi, | ||
| ...queryMockApi, | ||
| at: (_hash: Hash) => mockHistoricalApi, | ||
| } as unknown as ApiPromise; |
There was a problem hiding this comment.
dq: why is it necessary to cast to unknown before casting to ApiPromise?
There was a problem hiding this comment.
This is because the typescript compiler will have issues when converting or typecasting the original type to the newly assigned one (almost like a merge conflict). Therefore, unknown allows us to give the object a clean slate before assigning it a new type.
| const epochIndexAt = (_hash: Hash) => | ||
| Promise.resolve().then(() => polkadotRegistry.createType('u64', 330)); | ||
|
|
||
| const genesisSlotAt = (_hash: Hash) => |
There was a problem hiding this comment.
What is a "slot" in this context?
There was a problem hiding this comment.
The slot at which the first epoch actually started. This is 0
until the first block of the chain.
This slot is not to be confused with the parachain slot. It has to do with the BABE block production mechanism.
An epoch is a contiguous number of slots (From the substrate docs)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of: #699
The purpose of this PR is to restructure the mockApi, and create an adjacent mockHistoricalApi. Since we are removing all the query...at() calls we need to reflect that in the tests. I am taking this time to also reorganize our mockApis and isolate the tests even more. None of the unit tests themselves are being changed, just the structure, and organization.
Another benefit of this PR will be that when its time to transition a Service's structure for querying historical blocks in this Tracking Issue #698
Services:
BlocksService.spec.tsBlocksTraceService.spec.tsAccountsAssetsService.spec.tsAccountsBalanceInfoService.spec.tsAccountsStakingInfoService.spec.tsAccountsVestingInfoService.spec.tsNodeNetworkService.spec.tsNodeTransactionPoolService.spec.tsNodeVersionService.spec.tsPalletsAssetsService.spec.tsPalletsStakingProgressService.spec.tsPalletsStorageService.spec.tsParasService.spec.tsRuntimeCodeService.spec.tsRuntimeMetadataService.spec.tsRuntimeSpecService.spec.tsTransactionFeeEstimateService.spec.tsTransactionMaterialService.spec.tsTransactionSubmitService.spec.tsExtras
Cleanup MockApi