Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update blockWeights store for westend and kusama #740

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Oct 28, 2021

Updates the blockWeights Store for both westend and kusama with the most up to date runtimes.

@TarikGul TarikGul changed the title fix: update blockstore for westend and kusama fix: update blockWeights store for westend and kusama Oct 28, 2021
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why isn't polkadot bumped as well?

@@ -12,7 +12,7 @@ export const kusamaDefinitions: MetadataConsts[] = [
{
runtimeVersions: [
2027, 2028, 2029, 2030, 9000, 9010, 9030, 9040, 9050, 9070, 9080, 9090,
9100, 9110, 9111,
9100, 9110, 9111, 9122,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9120 is missing?

Included in v0.9.12 AFAIU

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DQ: How would I go about verifying that this list of versions is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9120 is missing?

Kusama doesnt have 9120 actually (or atleast via polkadot-js types known).

DQ: How would I go about verifying that this list of versions is correct?

https://github.com/polkadot-js/api/blob/master/packages/types-known/src/upgrades/kusama.ts

It is updated pretty religiously.

@TarikGul
Copy link
Member Author

TarikGul commented Nov 1, 2021

why isn't polkadot bumped as well?

@niklasad1 In this case I am just following Jaco. I didnt add it to the list in blocksStore, the idea being, what if polkadot doesnt have 9122 but instead they have to bump the runtime to v9123 before parachains are launched or something of the liking which ends up skipping v9122.

@TarikGul TarikGul merged commit 4686634 into master Nov 1, 2021
@TarikGul TarikGul deleted the tarik-update-blockstore branch November 1, 2021 13:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants