fix: support calc fee for Karura and Acala #754
Conversation
| export const karuraDefinitions: MetadataConsts[] = [ | ||
| { | ||
| runtimeVersions: [ | ||
| 1000, 1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010, 1011, |
There was a problem hiding this comment.
Do we need to list all the runtime versions? Do we need to PR here if we did a runtime upgrade?
There was a problem hiding this comment.
Yea and yes. If it doesnt have your new runtime version immediately thats alright, we just end up searching the decorated metadata for the weights for the missing runtime then cache it for the server instance.
| @@ -63,6 +63,9 @@ impl Multiplier { | |||
|
|
|||
| ("calamari", _v) => V2(new_u128(inner)), | |||
|
|
|||
| ("karura", _v) => V2(new_u128(inner)), | |||
There was a problem hiding this comment.
should be a way to configure this without modify rust code. at least for common cases.
There was a problem hiding this comment.
Yea we have had discussion about this, especially since parachains are going to want more and more support for fee calculations as time moves on. We thought about a plugin, and some different options. Still something to consider but I agree.
|
I will test it for you as well. But if you want to test it locally it's pretty simple. Just link the calc/pkg in the So it should look like this for the "@substrate/calc": "file:./calc/pkg" Then |
Thanks. I guess this needs to be part of README? |
|
Trie a few block of Karura and the number is matching values from Subscan. |
TarikGul
changed the title
|
Sweet, ran it locally and it checks out.
Good point. I'll write up some proper guide for it. |
TarikGul
requested review from
niklasad1,
maciejhirsz,
dvdplm,
emostov and
jsdw
|
As a note, this will be reflected in the next release of sidecar. Merging. |
I cannot test locally. I guess it is because we need to publish the calc package first before the wasm can be used.