fix: support manta parachain fee calculations #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
reviewed
Nov 16, 2021
| @@ -8,3 +8,7 @@ else | |||
| echo "Fee debugging enabled" | |||
| wasm-pack build --debug --target nodejs --scope substrate "$SCRIPT_DIR" -- --features debug | |||
| fi | |||
| # append a newline to pkg/package.json if it isn't there | |||
| if [ "$(tail -c1 "$SCRIPT_DIR/pkg/package.json"; echo x)" != $'\nx' ]; then | |||
|
Thanks for the PR and contribution, looks good so far, just going to run it locally as well. |
TarikGul
approved these changes
Nov 16, 2021
TarikGul
requested review from
maciejhirsz,
niklasad1,
dvdplm,
insipx and
jsdw
insipx
approved these changes
Nov 16, 2021
|
Just give the thumbs up when you are happy with this to merge. @grenade |
we're happy for this to be merged! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may be tested against any of: