fix: update polkadot-js deps, and fix tests, and types for assets #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
approved these changes
Nov 29, 2021
niklasad1
reviewed
Nov 29, 2021
| '10': assetBalanceObjOne as PalletAssetsAssetBalance, | ||
| '20': assetBalanceObjTwo as PalletAssetsAssetBalance, | ||
| '30': assetBalanceObjThree as PalletAssetsAssetBalance, | ||
| '10': assetBalanceObjOne as unknown as PalletAssetsAssetBalance, |
There was a problem hiding this comment.
can you explain why the unknown type casts are needed?
There was a problem hiding this comment.
Yea because the typescript compiler doesnt have the ability to cast Obj A as Obj B since their contents are not the exact same type structure. PalletAssetsAssetBalance has a extra field of type Null that we don't add for this specific test because it's not needed.
niklasad1
approved these changes
Nov 29, 2021
insipx
approved these changes
Nov 29, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following deps:
Before our type
IAssetBalancewas representingbalance: TAssetBalance(whereTAssetBalanceisu64). Now that polkadot-js represents the balance inPalletAssetsAssetBalance, the type for balance isu128. This is now reflected in the types, and tests.Update
AssetDetails->PalletAssetsAssetDetails