Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump polkadot-js deps #796

Merged
merged 9 commits into from
Dec 21, 2021
Merged

fix: bump polkadot-js deps #796

merged 9 commits into from
Dec 21, 2021

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Dec 20, 2021

This iteration of bumping the polkadot-js introduces many breaking changes.

  1. Imports for types have changed. For Codec types the import now comes from @polkadot/types-codec

  2. Block.registry -> CodecRegistry (which does not contain the createType method), therefore we replace it with the historicApis Registry.

  3. Add import '@polkadot/api-augment'; to the entry file noted by the @polkadot/api release in order to maintain the types used in the codebase.

  4. Retrieve PromiseRpcResult from @polkadot/api-base/types

Changed polkadot versions:

    "@polkadot/api": "^7.0.1",
    "@polkadot/apps-config": "0.98.2-164",
    "@polkadot/util-crypto": "^8.2.2",

closes: #771

@TarikGul TarikGul requested a review from a team December 20, 2021 11:21
Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me!

@TarikGul TarikGul merged commit c79d126 into master Dec 21, 2021
@TarikGul TarikGul deleted the tarik-bump-deps branch December 21, 2021 13:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e tests warns about deprecated subsocial dependency
4 participants