fix(calc): add tests for impl Multplier #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
reviewed
Jan 11, 2022
|
|
||
| #[test] | ||
| fn multiplier_from_spec_name() { | ||
| let inner = "500000000"; |
There was a problem hiding this comment.
I'm no fan of calling this inner, what is it multiplier (coefficient)?
fine, it's used widely in this crate....
There was a problem hiding this comment.
Yea I agree that it's not the most informative naming, and I'd be happy to update it to something more verbose in a follow up PR, but for this PR as you mentioned its probably wise to keep the continuity in the crate.
niklasad1
approved these changes
Jan 11, 2022
emostov
approved these changes
Jan 11, 2022
insipx
approved these changes
Jan 11, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for
impl Multiplier;Todo: