Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add fee calculation support and block weights for Astar network #820

Merged
merged 3 commits into from
Jan 25, 2022
Merged

fix: add fee calculation support and block weights for Astar network #820

merged 3 commits into from
Jan 25, 2022

Conversation

hoonsubin
Copy link
Contributor

This PR adds a controller and metadata consts for Astar network.

@hoonsubin hoonsubin requested a review from a team as a code owner January 18, 2022 10:07
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Jan 18, 2022

User @akru, please sign the CLA here.

@TarikGul
Copy link
Member

Looks good overall, I will give it a local run later as well.
Just need to sign the CLA, in order to have the CI pass.

TarikGul
TarikGul approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 Just needs the CLA

@hoonsubin
Copy link
Contributor Author

lgtm 👍 Just needs the CLA

Me and @akru already signed the cla, but the CI status doesn't seem to change. Any fixes?

@TarikGul TarikGul changed the title add fee calculation support and block weights for Astar network fix: add fee calculation support and block weights for Astar network Jan 19, 2022
@joao-paulo-parity
Copy link

lgtm +1 Just needs the CLA

Me and @akru already signed the cla, but the CI status doesn't seem to change. Any fixes?

We track the CLA signatures by the GitHub user id. @akru of GitHub user id 786394 (https://api.github.com/users/akru) has a signature for the old revision of the CLA which was replaced by the new revision since 2020. Please sign the latest revision at https://cla.parity.io/sign_cla/786394/3 and ping me in case the status does not change.

@akru
Copy link
Contributor

akru commented Jan 19, 2022

@joao-paulo-parity done

@TarikGul
Copy link
Member

@akru @hoonsubin Just a heads up when this goes in, it will be part of next weeks release! (Most likely tuesday).

@TarikGul TarikGul merged commit 1c5f16a into paritytech:master Jan 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emostov emostov emostov approved these changes

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoonsubin @TarikGul @joao-paulo-parity @akru @emostov