fix: Retrieving public endpoints with createWsEndpoints function
#829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imod7
changed the title
createWsEndpoints function
niklasad1
reviewed
Feb 1, 2022
- Replaced while with map and filter. - Fixed lint errors.
Imod7
commented
Feb 1, 2022
TarikGul
changed the title
createWsEndpoints functioncreateWsEndpoints function
|
LGTM, great job, and thank you for the PR. |
TarikGul
approved these changes
Feb 1, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
This PR is an attempt to solve the #782 issue.
Suggested Solution
I used
createWsEndpointsfunction to get the endpoints from @polkadot/apps-config/endpoints and then generated the newpublicWsUrlsarray.Note : I have not used the
specNameas suggested in #782