Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update polkadot-js/api, and rxjs #830

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Feb 1, 2022

Updates deps to the following:

"@polkadot/api": "^7.6.1",
"rxjs": "^7.5.2",

@TarikGul TarikGul requested a review from a team as a code owner February 1, 2022 04:10
@TarikGul
Copy link
Member Author

TarikGul commented Feb 1, 2022

This introduces a warning every time a new runtime is queried but wont appear again once its cached:

2022-01-31 23:12:45 warn: ABLEREGISTRY: Unable to determine runtime Call type, cannot inspect sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic
2022-01-31 23:12:45 warn: ABLEREGISTRY: Unable to determine runtime Event type, cannot inspect frame_system::EventRecord

Introduced via: polkadot-js/api@a650ae1

@niklasad1
Copy link
Member

This introduces a warning every time a new runtime is queried but wont appear again once its cached:

Have you filed an issue upstream? However, it's just a warn shouldn't be a big deal I suppose.

@TarikGul
Copy link
Member Author

TarikGul commented Feb 1, 2022

This introduces a warning every time a new runtime is queried but wont appear again once its cached:

Have you filed an issue upstream? However, it's just a warn shouldn't be a big deal I suppose.

So I believe this is already known, as it's checking parachains metadata which explains why it only warns for relay chains. But that being said, it should be logging PORTABLEREGISTRY instead of ABLEREGISTRY which i'll report.

@TarikGul
Copy link
Member Author

TarikGul commented Feb 2, 2022

The warning's are still going to be there, but after doing some extensive testing, and reading the code, this is a non issue so I am merging. I will follow up in polkadot-js api as well.

@TarikGul TarikGul merged commit 90083d1 into master Feb 2, 2022
@TarikGul TarikGul deleted the tarik-update-pjs branch February 2, 2022 14:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants