Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable experimental trace endpoints on polkadot #868

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

TarikGul
Copy link
Member

cc:/ @emostov

Enables the tracing endpoints for polkadot.

@TarikGul TarikGul requested a review from a team as a code owner March 10, 2022 14:52
@emostov
Copy link
Contributor

emostov commented Mar 10, 2022

What is the motivation? Can we just instruct people to add this on their own?

@TarikGul
Copy link
Member Author

Yea I'm fine with closing this and instructing others who want to test this out to add it within the controller config themselves. @Imod7 had brought it up, and tried to run traces with polkadot locally, so my idea was to just add it in as an experimental.

But there is definitely no large precedent.

@Imod7
Copy link
Contributor

Imod7 commented Mar 10, 2022

I did the change locally (added the BlocksTrace controller for polkadot), run a polkadot node with flag --unsafe-rpc-external but still I cannot see the trace endpoints on sidecar. So I guess there is also another change that I need to do in the node level ?

@TarikGul
Copy link
Member Author

I did the change locally (added the BlocksTrace controller for polkadot), run a polkadot node with flag --unsafe-rpc-external but still I cannot see the trace endpoints on sidecar. So I guess there is also another change that I need to do in the node level ?

I sanity checked this PR before pushing it up and the traces endpoints worked. Did you use yarn build to recompile the code, or are you using yarn dev?

@Imod7
Copy link
Contributor

Imod7 commented Mar 10, 2022

I run a polkadot node with this command :
./target/release/polkadot --chain=polkadot-dev --tmp --rpc-cors=all --alice --unsafe-rpc-external

Then in sidecar I run
yarn build
substrate-api-sidecar

@TarikGul
Copy link
Member Author

So it should actually be
yarn build
yarn start

@emostov emostov self-requested a review March 10, 2022 21:06
Copy link
Contributor

@0xslipk 0xslipk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TarikGul TarikGul merged commit 37c35ae into master Mar 11, 2022
@TarikGul TarikGul deleted the tarik-enable-polkadot-trace branch March 11, 2022 16:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants