-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable experimental trace endpoints on polkadot #868
Conversation
What is the motivation? Can we just instruct people to add this on their own? |
Yea I'm fine with closing this and instructing others who want to test this out to add it within the controller config themselves. @Imod7 had brought it up, and tried to run traces with polkadot locally, so my idea was to just add it in as an experimental. But there is definitely no large precedent. |
I did the change locally (added the |
I sanity checked this PR before pushing it up and the traces endpoints worked. Did you use |
I run a polkadot node with this command : Then in sidecar I run |
So it should actually be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc:/ @emostov
Enables the tracing endpoints for polkadot.